[GLUTEN-9288][VL] Enable array_prepend function for spark 3.5+#9305
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
dcoliversun
force-pushed
the
gluten-9288
branch
from
d71befc to
56b2446
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
cc @philo-he @jinchengchenghh Could you please have a review for this? Thanks |
dcoliversun
commented
Apr 14, 2025
…lox/VeloxSparkPlanExecApi.scala
|
Run Gluten Clickhouse CI on x86 |
philo-he
reviewed
Apr 15, 2025
philo-he
left a comment
philo-he
left a comment
Member
There was a problem hiding this comment.
Looks good! Just two trivial comments. Thanks!
| original: Expression): ExpressionTransformer = { | ||
| children match { | ||
| case Seq(left, posExpr, right, _) if posExpr.original == Literal(1) => | ||
| // transformer to array_prepend implement in velox |
Member
There was a problem hiding this comment.
Nit: remove this comment or rephrase it like: Transformer for array_prepend. (follow community comment style: capitalize initial letter and end up with period).
Contributor
Author
There was a problem hiding this comment.
Update with Transformer for array_prepend.
dcoliversun
commented
Apr 15, 2025
…lox/VeloxSparkPlanExecApi.scala
dcoliversun
commented
Apr 15, 2025
…arFunctionsValidateSuite.scala
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable array_prepend function for spark3.5+.
(Fixes: #9288)
How was this patch tested?
Unit test.