[CORE] Remove library unloading API from JniLibLoader as unused#9277
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API was originally added for CH backend library unloading. Now the C++ side JNI_OnUnload implmentation in CH backend was removed in #9242. So we don't need this API in Java-side as well ideally.
The invocation code to Java side unload API relies on reflections and some uncertain promises from JVM. Its portability is not verified and maintenance will also be an issue. It's the main reason we do the removal and avoid introducing a similar mechanism in future also.