Skip to content

[GLUTEN-8520][VL] Fix bitwise operators#8521

Merged
FelixYBW merged 1 commit into
apache:mainfrom
jkhaliqi:jk_cve_bitwise_ops
Jan 15, 2025
Merged

[GLUTEN-8520][VL] Fix bitwise operators#8521
FelixYBW merged 1 commit into
apache:mainfrom
jkhaliqi:jk_cve_bitwise_ops

Conversation

@jkhaliqi

@jkhaliqi jkhaliqi commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Use bitwise operators only on unsigned operands
False positives
cpp/velox/tests/MemoryManagerTest.cc:43
cpp/velox/benchmarks/ColumnarToRowBenchmark.cc:215
cpp/core/shuffle/RoundRobinPartitioner.cc:39
cpp/velox/compute/WholeStageResultIterator.cc:255
cpp/core/shuffle/HashPartitioner.cc:55
cpp/velox/tests/VeloxColumnarToRowTest.cc:37
cpp/core/shuffle/FallbackRangePartitioner.cc:44
cpp/velox/benchmarks/ColumnarToRowBenchmark.cc:160
cpp/velox/tests/MemoryManagerTest.cc:343
cpp/core/benchmarks/CompressionBenchmark.cc:306
cpp/core/shuffle/RandomPartitioner.cc:36
cpp/core/utils/qat/QatCodec.cc:152
cpp/velox/shuffle/VeloxShuffleReader.cc:542
cpp/velox/tests/VeloxRowToColumnarTest.cc:36
cpp/velox/tests/MemoryManagerTest.cc:346
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:366
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:416
cpp/velox/benchmarks/ColumnarToRowBenchmark.cc:153
cpp/velox/benchmarks/ParquetWriteBenchmark.cc:162
cpp/velox/benchmarks/ParquetWriteBenchmark.cc:255
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:30
cpp/core/utils/qpl/QplJobPool.cc:70
cpp/velox/memory/VeloxMemoryManager.cc:263
cpp/velox/operators/serializer/VeloxRowToColumnarConverter.cc:107
cpp/velox/memory/VeloxMemoryManager.cc:41
cpp/velox/utils/tests/MemoryPoolUtils.cc:131
cpp/velox/operators/serializer/VeloxRowToColumnarConverter.cc:39
cpp/core/utils/qpl/QplCodec.cc:206
cpp/velox/operators/serializer/VeloxRowToColumnarConverter.cc:183
cpp/velox/memory/VeloxMemoryManager.cc:43

(Fixes: #8520)

@github-actions github-actions Bot added the VELOX label Jan 13, 2025
@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@jkhaliqi jkhaliqi changed the title [GLUTEN_8520][VL] Fix bitwise operators Jan 13, 2025
@github-actions

Copy link
Copy Markdown
@jkhaliqi jkhaliqi marked this pull request as ready for review January 14, 2025 00:20
@FelixYBW FelixYBW merged commit 6b92e88 into apache:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants