Skip to content

[GLUTEN-10635][VL] bugfix: file INSTALL cannot set permissions#10638

Merged
philo-he merged 3 commits into
apache:mainfrom
beliefer:10635
Sep 9, 2025
Merged

[GLUTEN-10635][VL] bugfix: file INSTALL cannot set permissions#10638
philo-he merged 3 commits into
apache:mainfrom
beliefer:10635

Conversation

@beliefer

@beliefer beliefer commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

This PR proposes to fix a building bug.
Fixes #10635

How was this patch tested?

GA tests.

@github-actions github-actions Bot added the BUILD label Sep 5, 2025
@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown
@Zouxxyy

Zouxxyy commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

I actually encountered this problem when running build_arrow on my Mac, and I was confused as to why arrow was installed in a fixed location like this cmake --install ./ --prefix /usr/local/. Instead of using INSTALL_PREFIX

if [[ "$(uname)" == "Darwin" ]]; then
    INSTALL_PREFIX=${INSTALL_PREFIX:-${VELOX_HOME}/deps-install}
else
    INSTALL_PREFIX=${INSTALL_PREFIX:-"/usr/local"}
fi

Maybe we need a fix? @zhouyuan

@philo-he

philo-he commented Sep 8, 2025

Copy link
Copy Markdown
Member

@Zouxxyy, MacOS was not properly considered in the Arrow installation. You can propose a fix to use a path more suitable for MacOS. Maybe, you can just replace /usr/local with $INSTALL_PREFIX in build_arrow.sh.

Comment thread dev/build_helper_functions.sh Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just let user fix this issue by setting SUDO=sudo in the environment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tried in this way. But it is still not working.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pease try to add this line in the beginning of this file?
https://github.com/apache/incubator-gluten/blob/main/dev/build_arrow.sh#L21

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems line 21 should be changed to SUDO="${SUDO:-""}", where all letters are capitalized. Then, I assume setting SUDO=sudo in the environment should work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems line 21 should be changed to SUDO="${SUDO:-""}", where all letters are capitalized. Then, I assume setting SUDO=sudo in the environment should work.

I tried this way, it works well. But I don't know if it will affect other OS.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beliefer, I suggest to just fix this line, and let users explicitly set the environment variable if they meet such permission issue.

@Zouxxyy

Zouxxyy commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

@Zouxxyy, MacOS was not properly considered in the Arrow installation. You can propose a fix to use a path more suitable for MacOS. Maybe, you can just replace /usr/local with $INSTALL_PREFIX in build_arrow.sh.

Sure, can you have a look at #10650, thanks

@beliefer beliefer requested a review from philo-he September 8, 2025 07:20

@philo-he philo-he left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@philo-he philo-he merged commit baaa782 into apache:main Sep 9, 2025
9 checks passed
@beliefer

beliefer commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@philo-he @zhouyuan Thank you!

wForget pushed a commit to wForget/gluten that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants