[GLUTEN-10618][VL] Update input iterator metrics name to include more details#10619
Merged
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
FelixYBW
reviewed
Sep 5, 2025
| // For input from shuffle, the time of shuffle read is inclusive to the metrics. | ||
| SQLMetrics.createNanoTimingMetric( | ||
| sparkContext, | ||
| "time of input iterator (shuffle read time inclusive)") |
Contributor
There was a problem hiding this comment.
name is too long. Can you rename it as "time of reducer input"
FelixYBW
reviewed
Sep 5, 2025
| // For input from broadcast, the time of broadcasting is exclusive. | ||
| SQLMetrics.createNanoTimingMetric( | ||
| sparkContext, | ||
| "time of input iterator (broadcast time exclusive)") |
Contributor
There was a problem hiding this comment.
change to "time of broadcast input"
FelixYBW
reviewed
Sep 5, 2025
| // For other occasions, e.g. fallback, union, the time of the previous pipeline is inclusive. | ||
| SQLMetrics.createNanoTimingMetric( | ||
| sparkContext, | ||
| "time of input iterator (previous pipeline time inclusive)") |
|
Run Gluten Clickhouse CI on x86 |
FelixYBW
approved these changes
Sep 8, 2025
FelixYBW
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.