[TEST][VL] Reinclude "cast string to timestamp" test#10532
Merged
Conversation
…stamp (apache#10518)" This reverts commit 7fd10da.
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
philo-he
force-pushed
the
re-include-test
branch
from
fcbc249 to
cfd88e1
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
philo-he
force-pushed
the
re-include-test
branch
from
aab659f to
1da776f
Compare
|
Run Gluten Clickhouse CI on x86 |
philo-he
force-pushed
the
re-include-test
branch
from
1da776f to
a3e31a8
Compare
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
@zhouyuan, could you review this PR? |
Closed
16 tasks
zhouyuan
pushed a commit
to zhouyuan/gluten
that referenced
this pull request
Aug 28, 2025
zhouyuan
added a commit
that referenced
this pull request
Aug 28, 2025
…10576) * [VL][INFRA] Fix docker build error on Centos-7 (#10522) * [TEST][VL] Reinclude "cast string to timestamp" test (#10532) * [GLUTEN-10552][VL] Fix openEuler compiling issue (#10564) This patch adds a extra gcc flag -Wno-restrict to workaround the openeuler compiling issue Velox did added this for gcc-12.2.1 however openeuler is using gcc-12.3.1 https://github.com/facebookincubator/velox/blob/main/CMakeLists.txt#L408 fixes: #10552 --------- Signed-off-by: Yuan <yuanzhou@apache.org> --------- Signed-off-by: Yuan <yuanzhou@apache.org> Co-authored-by: PHILO-HE <philo@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR reverts a3a6b39.
The root cause of the UT failure is that we removed the installation of the new tzdata after confirming that the old tzdata was compatible with Velox. However, the old tzdata does not work correctly for the following timezones: "Asia/Tehran" and "Iran". These timezones appear to be uncommon. This PR simply excludes these two timezones from the test.
Additionally, to enhance debuggability, this PR introduces a helper method to log error messages when using
ThreadUtils.parmapfor multi-threaded testing.How was this patch tested?
The test passed.