Skip to content

FINERACT-2404: Improved extensibility and cleanup#5141

Merged
adamsaghy merged 1 commit intoapache:developfrom
cucusenok:develop-2404
Nov 7, 2025
Merged

FINERACT-2404: Improved extensibility and cleanup#5141
adamsaghy merged 1 commit intoapache:developfrom
cucusenok:develop-2404

Conversation

@cucusenok
Copy link

@cucusenok cucusenok commented Nov 4, 2025 •
edited
Loading

Checklist

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
@adamsaghy
Copy link
Contributor

adamsaghy commented Nov 4, 2025

@cucusenok You should leave the version out from the commit message and PR title.
adamsaghy
adamsaghy reviewed Nov 4, 2025
View reviewed changes
@cucusenok cucusenok changed the title FINEREACT-2404: Improved extensibility and cleanup for 1.13.1 Nov 4, 2025
@cucusenok
Copy link
Author

cucusenok commented Nov 4, 2025

@cucusenok You should leave the version out from the commit message and PR title.

The commit message and PR title have been updated
adamsaghy
adamsaghy reviewed Nov 4, 2025
View reviewed changes
@cucusenok
Copy link
Author

cucusenok commented Nov 4, 2025

@adamsaghy All mentioned access modifiers have been changed from public to protected
@cucusenok cucusenok marked this pull request as ready for review November 4, 2025 10:38
@adamsaghy adamsaghy merged commit 9320dd1 into apache:develop Nov 7, 2025
33 checks passed
@meonkeys meonkeys changed the title FINEREACT-2404: Improved extensibility and cleanup Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@cucusenok @adamsaghy