FINERACT-2358: Advanced-accounting-rules-based-on-write-off-reason E2E tests#5075
Merged
galovics merged 1 commit intoapache:developfrom Oct 15, 2025
Conversation
alberto-art3ch
force-pushed
the
FINERACT-2358/Backend-Advanced-accounting-rules-based-on-write-off-reason
branch
2 times, most recently
from
68d1b43 to
f2cc6ce
Compare
fineract-e2e-tests-runner/src/test/resources/features/LoanWriteOff.feature
Outdated
Show resolved
Hide resolved
budaidev
reviewed
Oct 13, 2025
| this.helper.createDebitJournalEntryForLoan(office, currencyCode, AccrualAccountsForLoan.LOSSES_WRITTEN_OFF.getValue(), | ||
| loanProductId, paymentTypeId, loanId, transactionId, transactionDate, totalDebitAmount); | ||
| } else { | ||
| this.helper.createDebitJournalEntryForLoan(office, currencyCode, mapping.getGlAccount(), loanId, transactionId, |
Contributor
There was a problem hiding this comment.
is it possible to have mapping but no glAcccount? What happens in this case?
Contributor
There was a problem hiding this comment.
If you have a mapping you must to have a GLAccount
fineract-e2e-tests-runner/src/test/resources/features/LoanWriteOff.feature
Outdated
Show resolved
Hide resolved
alberto-art3ch
force-pushed
the
FINERACT-2358/Backend-Advanced-accounting-rules-based-on-write-off-reason
branch
from
f2cc6ce to
60573bf
Compare
budaidev
approved these changes
Oct 14, 2025
galovics
approved these changes
Oct 14, 2025
somasorosdpc
approved these changes
Oct 15, 2025
galovics
deleted the
FINERACT-2358/Backend-Advanced-accounting-rules-based-on-write-off-reason
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.