GH-49003: [C++] Don't consider out_of_range an error in float parsing
#49095
+21
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR restores the behavior previous to version 23 for floating-point parsing on overflow and subnormal.
fast_floatdidn't assign an error code on overflow in version3.10.1and assigned±Infon overflow and0.0on subnormal. With the update to version8.1, it started to assignstd::errc::result_out_of_rangein such cases.What changes are included in this PR?
Ignores
std::errc::result_out_of_rangeand produce±Inf/0.0as appropriate instead of failing the conversion.Are these changes tested?
Yes. Created tests for overflow with positive and negative signed mantissa, and also created tests for subnormal, all of them for binary{16,32,64}.
Are there any user-facing changes?
It's a user facing change. The CSV reader on version
libarrow==23was assigning them as strings, while before it was parsing it as0or+- inf.With this patch, the CSV reader in PyArrow outputs:
Closes #49003