GH-49081: [C++][Parquet] Correct variant's extension name #49082
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
wgtmac
reviewed
Jan 31, 2026
| explicit VariantExtensionType(const std::shared_ptr<::arrow::DataType>& storage_type); | ||
|
|
||
| std::string extension_name() const override { return "parquet.variant"; } | ||
| std::string extension_name() const override { return "arrow.parquet.variant"; } |
Member
There was a problem hiding this comment.
This change looks good.
Do you think it is worth adding a kVariantExtensionName in this file and move this file to cpp/src/arrow/extension/parquet_variant.h?
WDYT? @pitrou
Contributor
Author
There was a problem hiding this comment.
JsonExtensionType also uses hardcoded extension name. If we want to define string literals, I suggest to move other's extension types' names into a same file.
Contributor
Author
There was a problem hiding this comment.
Do we need to move variant_internal.h to cpp/src/arrow/extension/ like other extension types?
Member
There was a problem hiding this comment.
Yes, that's exactly what I proposed above.
github-actions
bot
added
awaiting committer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Correct variant extension according to arrow's specification.
What changes are included in this PR?
Modified variant's hardcoded extension name.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.