-
Notifications
You must be signed in to change notification settings - Fork 16.2k
Fix log task instance join #59973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Subham-KRLX
wants to merge
7
commits into
apache:main
Choose a base branch
from
Subham-KRLX:fix-log-task-instance-join
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix log task instance join #59973
+78
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence - Remove separate TimeDeltaSensorAsync documentation section - Add reference to official deferring documentation - Show both sync and deferrable examples using TimeDeltaSensor Related: apache#59644
Prab-27
reviewed
Dec 31, 2025
| :end-before: [END example_time_delta_sensor] | ||
|
|
||
|
|
||
| .. _howto/operator:TimeDeltaSensorAsync: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes unrelated to this PR?
Could you please check? I believe these changes are related to this PR. #59651
Contributor
|
Thanks for the pr! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect Log and TaskInstance join query
This PR addresses the issue: Incorrect log and task instance join query based on task_id in eventLogs API #59965.
The Log.task_instance relationship in
airflow/models/log.py
has been updated to use a strict join on the following fields:
dag_id
task_id
run_id
map_index
This change ensures that log entries are correctly associated with their corresponding task instances, resolving an issue where the relationship was previously defined with a primaryjoin that only checked for matching
task_id.