Skip to content

feat(desktop): add hover background to session title and single-click edit#34589

Merged
Brendonovich merged 1 commit into
devfrom
session-title-hover
Jun 30, 2026
Merged

feat(desktop): add hover background to session title and single-click edit#34589
Brendonovich merged 1 commit into
devfrom
session-title-hover

Conversation

@usrnk1

@usrnk1 usrnk1 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #

Type of change

  • New feature

What does this PR do?

For new layout designs, improves the session title editing UX:

  • Adds an overlay hover background (hover:bg-v2-overlay-simple-overlay-hover) on the session title to indicate it's editable
  • Changes edit trigger from double-click to single-click (hover background makes affordance clear)
  • Uses w-fit with px-2 so the hover bg only covers the text width, not the full container
  • Aligns the static h1 and inline-edit <input> box model (px-2, -ml-2, rounded-[6px]) to prevent layout shift when entering edit mode
  • Reduces left padding from pl-4 to pl-2

How did you verify your code works?

  • bun turbo typecheck passes across all packages

Screenshots / recordings

Screenshot.2026-06-30.at.10.59.24.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR
For new layout designs:
- Add overlay hover background on session title to indicate editability
- Change edit trigger from double-click to single-click
- Use w-fit with padding so hover bg matches text width
- Align static and inline-edit box model to prevent layout shift
- Reduce left padding from pl-4 to pl-2
@usrnk1 usrnk1 requested review from Brendonovich and Hona as code owners June 30, 2026 09:23
@github-actions github-actions Bot added contributor needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@usrnk1 usrnk1 self-assigned this Jun 30, 2026
@usrnk1 usrnk1 changed the title feat(app): add hover background to session title and single-click edit Jun 30, 2026
@Brendonovich Brendonovich merged commit f69f677 into dev Jun 30, 2026
16 of 20 checks passed
@Brendonovich Brendonovich deleted the session-title-hover branch June 30, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants