fix(opencode): surface content-filter finish reason as visible error#31745
Merged
rekram1-node merged 2 commits intoJun 11, 2026
Merged
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Collaborator
|
thank u! |
isaacfinnegan
pushed a commit
to isaacfinnegan/whispercode
that referenced
this pull request
Jun 15, 2026
…nomalyco#31745) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
leduyphuc1702
pushed a commit
to leduyphuc1702/opencode-workflow
that referenced
this pull request
Jun 16, 2026
Inherits upstream anomalyco#31745, adapted to fork's structure: ContentFilterError added to session/message-v2 (fork's MessageV2 errors, not upstream core/v1/session) + AssistantErrorSchema, handler in prompt.ts finish region, SDK types.gen.ts + openapi.json updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
davidgut1982
pushed a commit
to davidgut1982/opencode
that referenced
this pull request
Jun 19, 2026
…nomalyco#31745) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
markjaquith
pushed a commit
to markjaquith/opencode
that referenced
this pull request
Jun 23, 2026
…nomalyco#31745) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
BenGu3
pushed a commit
to BenGu3/opencode
that referenced
this pull request
Jun 27, 2026
…nomalyco#31745) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31744
Type of change
What does this PR do?
When a provider ends a turn with the
content-filterfinish reason (e.g. Anthropicstop_reason: refusal), no error was attached to the assistant message, so the prompt loop exited and the session went idle. If the turn produced no visible output, nothing rendered at all — it looked like opencode just stopped.This adds a
ContentFilterErrorto the assistant error union and attaches it in the prompt loop when a finished turn hasfinish === "content-filter"and no existing error, alongside publishingsession.error. This mirrors the existingStructuredOutputErrorhandling in the same block. The TUI and web app already render any non-abortedmessage.error, so no client changes were needed.How did you verify your code works?
refusal->content-filterinpackages/llm/src/protocols/anthropic-messages.ts, processor records the finish with no error, loop previously broke silently at the finish check inprompt.tsbun typecheckpasses across all 23 packages (pre-push hook)./packages/sdk/js/script/build.tsTo confirm: force a turn to finish with
content-filter— the assistant message now carriesContentFilterErrorand the UI shows the error box instead of nothing.Screenshots / recordings
N/A (renders through the existing error box UI)
Checklist