Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

docs(worker): Fix webpack integration info - #125

Open
joaogarin wants to merge 2 commits into
angular:masterfrom
joaogarin:patch-1
Open

joaogarin wants to merge 2 commits into
angular:masterfrom
joaogarin:patch-1

Conversation

@joaogarin

Copy link
Copy Markdown

I have noticed the AngularServiceWorkerPlugin is exported as default so to get a reference to the plugin one should be using :

const AngularServiceWorkerPlugin = require('@angular/service-worker/webpack').default;

Also fixing a little typo when calling the plugin "Plugion" to "Plugin"

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@joaogarin

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants