Skip to content

Feature/restricted range #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2018
Merged

Feature/restricted range #638

merged 4 commits into from
Jun 29, 2018

Conversation

@DanielReid
Copy link
Contributor

@DanielReid DanielReid commented Jun 29, 2018

See #583 (comment) (made new clean branch)
@DanielReid DanielReid mentioned this pull request Jun 29, 2018
Closed
@codecov-io
Copy link

codecov-io commented Jun 29, 2018 •
edited
Loading

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #638   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         950    970   +20     
=====================================
+ Hits          950    970   +20
Impacted Files Coverage Δ
src/rzslider.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6cae6...1ac0e2f. Read the comment docs.
ValentinH
ValentinH reviewed Jun 29, 2018
View reviewed changes
Copy link
Member

@ValentinH ValentinH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, really good PR, with docs and tests! Such a pleasure to review :)

Just added one comment for a question, then it's ready to merge in my opinion.
src/rzslider.js
)

// Initialize position cache properties
this.selBar.rzsp = 0
Copy link
Member

@ValentinH ValentinH Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this part?
@ValentinH
Copy link
Member

ValentinH commented Jun 29, 2018

ALso, I check the fiddle: https://jsfiddle.net/2hxm9cop/1/. Why is the restricted color not red?
image
@DanielReid
Copy link
Contributor Author

DanielReid commented Jun 29, 2018

Apologies, I messed up while squashing the old branch. Thanks for reviewing with attention!
@ValentinH
Copy link
Member

ValentinH commented Jun 29, 2018

Perfect! Releasing it right now at 6.6.0 :)
@ValentinH ValentinH merged commit 765cca1 into angular-slider:master Jun 29, 2018
@ValentinH
Copy link
Member

ValentinH commented Jun 29, 2018

Done 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@DanielReid @codecov-io @ValentinH