Skip to content

Remove outdated qualifiers on resources folders #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MGaetan89
Copy link
Contributor

Some resources were still in the -v21/-v22/-v23 resources folders.
This PR moves them to the main folder, updating the original files when needed.

@nift4
Copy link
Contributor

nift4 commented Jul 30, 2025

shouldn't this also remove .png files for example in ui library? while the .png files would still be used on devices that exactly match the standard dpi qualifiers, anydpi .xml files will be used for any other dpi, and frankly there is no reason to keep the app size bloat that are these .png files anymore as anydpi vector drawables work just fine for these.

@MGaetan89
Copy link
Contributor Author

Good point! I'll look into removing the PNG files when there is a vector equivalent

@tonihei
Copy link
Collaborator

tonihei commented Jul 31, 2025

shouldn't this also remove .png files for example in ui library

Yes, it should, thanks for noting! These pngs only existed to support API<21 devices, so can now be removed entirely.

@MGaetan89 MGaetan89 force-pushed the remove-outdated-res-qualifiers branch from 420bd6b to 9f6154f Compare July 31, 2025 08:34
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Jul 31, 2025

Done. I've removed PNG files that already have a vector equivalent in a0d7ba3, and converted exo_icon_circular_play to vector in c00d28f.

Note

There's still exo_icon_vr.png in :lib-ui that is not a vector, but I didn't find the icon on https://fonts.google.com/icons

@MGaetan89 MGaetan89 force-pushed the remove-outdated-res-qualifiers branch from 9f6154f to c00d28f Compare July 31, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants