Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@mytja
Copy link
Collaborator

@mytja mytja commented Mar 19, 2022

So, YouTube has added transcription (slovenian "Prepis"). Now we have Transcription classes with really minimal code.
image

Have added tests, but adding you as reviewers as you never know what you can find 😉.

@mytja mytja added the enhancement New feature or request label Mar 19, 2022
Copy link
Owner

@alexmercerind alexmercerind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 💚

Well, we surely have a lot of features in this library.

Copy link
Collaborator

@raitonoberu raitonoberu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well, great job! Just a couple of comments:

  • If subtitles are disabled in the video, it raises the Failed to extract key exception. It would be nice to add a proper way to handle this. Maybe just return an empty dict?
  • Now it returns transcriptions in English. How about adding a language selection option?
@mytja
Copy link
Collaborator Author

mytja commented Mar 19, 2022

  • If subtitles are disabled in the video, it raises the Failed to extract key exception. It would be nice to add a proper way to handle this. Maybe just return an empty dict?

This I will certainly fix, but I haven't got an example of video like this.

  • Now it returns transcriptions in English. How about adding a language selection option?

Will have a look.

@raitonoberu
Copy link
Collaborator

raitonoberu commented Mar 19, 2022

I haven't got an example of video like this.

Mostly various music videos (not sure how it works): https://www.youtube.com/watch?v=hzpt3fQjY9U

@mytja
Copy link
Collaborator Author

mytja commented Mar 19, 2022

Done.
Now user can retrieve different languages using params parameter, which I give them for specific language.

@mytja
Copy link
Collaborator Author

mytja commented Mar 19, 2022

I've also added Channel class, which displays channel info - Resolves #164

@mytja mytja changed the title Add Transcript class Mar 19, 2022
@mytja mytja linked an issue Mar 19, 2022 that may be closed by this pull request
@mytja
Copy link
Collaborator Author

mytja commented Mar 19, 2022

Will merge this tomorrow

@mytja mytja merged commit 23e5dcf into main Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

4 participants