This repository was archived by the owner on Jun 30, 2022. It is now read-only.
A lot of patches to Playlist class #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raitonoberu
approved these changes
Jan 29, 2022
Collaborator
raitonoberu
left a comment
raitonoberu
left a comment
There was a problem hiding this comment.
Good. Couldn't be better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #150 and Resolves #157
Have a look at respective comments, where I investigated every behaviour and of course fixed it:
I tested everything extensively and I hope it works just fine for everything. Adding you as reviewers, as you might be able to catch some bugs.
When it comes to tests for #157, we are on a thin line. From my testing of tests, I found out that YouTube denied some of my requests if I were to include this test. Thus we cannot include it, because we don't want failing tests, that are actually passing.
I added some more tests and also added contributors in README