Skip to content

feat(airbyte-cdk): add jinja macros today_with_timezone #48400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

artem1205
Copy link
Contributor

@artem1205 artem1205 commented Nov 7, 2024

What

Resolving Amazon Ads migration to low-code
lines

How

add jinja macros today_with_timezone

Review guide

  1. airbyte-cdk/python/airbyte_cdk/sources/declarative/interpolation/macros.py
  2. airbyte-cdk/python/unit_tests/sources/declarative/interpolation/test_jinja.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Nov 7, 2024
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Nov 7, 2024 0:31am
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 7, 2024
@artem1205 artem1205 marked this pull request as ready for review November 7, 2024 12:32
@artem1205 artem1205 requested a review from a team November 7, 2024 12:32
@artem1205
Copy link
Contributor Author

artem1205 commented Nov 8, 2024

/approve-regression-tests

Check job output.

✅ Approving regression tests

@artem1205 artem1205 merged commit 0c73a65 into master Nov 8, 2024
37 of 39 checks passed
@artem1205 artem1205 deleted the artem1205/airbyte-cdk-macros-today-timezone branch November 8, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
3 participants