feat(cdk): port QA checks from airbyte-ci to airbyte-python-cdk #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
|
Original prompt from Aaron: |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…ecture Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
aaronsteers
reviewed
May 1, 2025
Comment on lines
+107
to
+115
| config.addinivalue_line("markers", "qa_check: mark a test as a QA check") | ||
| config.addinivalue_line("markers", "check_category(category): mark a test with a check category") | ||
| config.addinivalue_line("markers", "connector_language(languages): mark a test as applicable to specific connector languages") | ||
| config.addinivalue_line("markers", "connector_type(types): mark a test as applicable to specific connector types") | ||
| config.addinivalue_line("markers", "connector_support_level(levels): mark a test as applicable to specific connector support levels") | ||
| config.addinivalue_line("markers", "connector_cloud_usage(usages): mark a test as applicable to specific connector cloud usages") | ||
| config.addinivalue_line("markers", "connector_ab_internal_sl(sl): mark a test as applicable to connectors with a specific ab_internal_sl") | ||
| config.addinivalue_line("markers", "requires_metadata: mark a test as requiring metadata") | ||
| config.addinivalue_line("markers", "runs_on_released_connectors: mark a test as running on released connectors") |
|
The markers are used to filter tests based on connector properties. We can simplify this by keeping only the essential ones: Essential markers:
Optional markers that could be removed:
I can reduce these to just the essential markers if preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports the quality assurance (QA) checks from airbyte-ci to the airbyte-python-cdk, creating a new module at
airbyte_cdk.qawith a CLI commandairbyte-cdk connector pre-release-check.Changes
airbyte_cdk.qawith the following components:models.pyforCheck,CheckResult, andReportclassesConnectorclass inconnector.pywith minimal dependenciessemverandpydashto support the QA checksConnectorandCheckResultclassesHow to test
Run the CLI command:
Requested by
Aaron ("AJ") Steers (aj@airbyte.io)
Link to Devin run
https://app.devin.ai/sessions/765c11efdefa43578eb78b1308e7b89a