-
Notifications
You must be signed in to change notification settings - Fork 18
chore: set up asdf with .tool-versions
#516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…n workflows Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Original prompt from Aaron:
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More places where matrix should have priority over tool versions file. I will apply these changes.
@@ -0,0 +1,2 @@ | |||
python 3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some workflows are using 3.10
it seems. - worth testing to make sure this bump doesn't break anything. Similarly workflows are not all using the same poetry version
Also unless there's a good reason not to, I like that this makes all workflows use the same versions
Note from AJ (@aaronsteers)
This is a spinoff from this Slack thread:
Idea is to keep things more DRY and reduce version drift for tools used in CI workflows.
In total, this PR replaces 20 hardcoded version refs for Python and/or Poetry, instead storing the version in a new
.tool-versions
file which we can maintain centrally.I've reviewed this PR and I think it's ready for others to review as well, esp. @bnchrch who's more experienced with asdf.
How
Link to GitHub Action docs:
marocchino/tool-versions-action
, which scrapes the file and creates outputs we can pass to other steps.Do developers have to use
asdf
?No. This step does not require everyone on the team to use
asdf
. The scope here is just CI, and creating the local.tool-versions
file. Developers can (if they want to) start usingasdf
, but that is not required for this PR to have positive value, since the emphasis here is really just on CI.Generated Summary (Devin):
Set up asdf with .tool-versions
This PR adds a .tool-versions file containing the tool versions currently used in GitHub Actions workflows and updates the workflows to use the marocchino/tool-versions-action. This allows managing tool versions in a single place.
Changes:
Requested by: Aaron ("AJ") Steers (aj@airbyte.io)
Link to Devin run: https://app.devin.ai/sessions/faac6654afb44c50b895d7e768f7c9aa