Skip to content

poc: connector builder using concurrent cdk #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

poc: connector builder using concurrent cdk #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5801629
tmp
maxi297 Apr 4, 2025
a56f079
fix tests
maxi297 Apr 4, 2025
b663cf5
poc with test_concurrent_perpartitioncursor still failing
maxi297 Apr 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@maxi297
maxi297 committed Apr 4, 2025
commit a56f079cb2fe890f364b33a7dc8ff9f051797ee6
1 change: 1 addition & 0 deletions airbyte_cdk/sources/declarative/interpolation/macros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ def format_datetime(
dt_datetime = (
datetime.datetime.strptime(dt, input_format) if input_format else str_to_datetime(dt)
)
dt_datetime = dt_datetime.replace(tzinfo=pytz.utc)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the scope of this PR. See https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1743795253674379 for more details
return DatetimeParser().format(dt=dt_datetime, format=format)


Expand Down
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/declarative/schema/default_schema_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def get_json_schema(self) -> Mapping[str, Any]:

try:
return self.default_loader.get_json_schema()
except OSError:
except (OSError, ValueError):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the scope of this PR. See https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1743795253674379 for more details
# A slight hack since we don't directly have the stream name. However, when building the default filepath we assume the
# runtime options stores stream name 'name' so we'll do the same here
stream_name = self._parameters.get("name", "")
Expand Down