Skip to content

chore(refactor): Remove Partition.close #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

chore(refactor): Remove Partition.close #32

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aaf1e7
Remove Partition.close
maxi297 Nov 12, 2024
640e7e6
Merge branch 'main' into issue-10552/remove-partition-close-method
aaronsteers Nov 13, 2024
c28d1c1
Auto-fix lint and format issues
Nov 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Auto-fix lint and format issues
  • Loading branch information
octavia-squidington-iii committed Nov 13, 2024
commit c28d1c1d51eab458937f006e2422903797a31dd8
14 changes: 12 additions & 2 deletions unit_tests/sources/file_based/stream/concurrent/test_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,12 @@ def test_file_based_stream_partition(transformer, expected_records):
cursor_field = None
state = None
partition = FileBasedStreamPartition(
stream, _slice, message_repository, sync_mode, cursor_field, state,
stream,
_slice,
message_repository,
sync_mode,
cursor_field,
state,
)

a_log_message = AirbyteMessage(
Expand Down Expand Up @@ -203,7 +208,12 @@ def test_file_based_stream_partition_hash(_slice, expected_hash):
stream = Mock()
stream.name = "stream"
partition = FileBasedStreamPartition(
stream, _slice, Mock(), _ANY_SYNC_MODE, _ANY_CURSOR_FIELD, _ANY_STATE,
stream,
_slice,
Mock(),
_ANY_SYNC_MODE,
_ANY_CURSOR_FIELD,
_ANY_STATE,
)

_hash = partition.__hash__()
Expand Down
4 changes: 1 addition & 3 deletions unit_tests/sources/streams/concurrent/test_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,7 @@ def test_stream_partition(transformer, expected_records):
sync_mode = SyncMode.full_refresh
cursor_field = None
state = None
partition = StreamPartition(
stream, _slice, message_repository, sync_mode, cursor_field, state
)
partition = StreamPartition(stream, _slice, message_repository, sync_mode, cursor_field, state)

a_log_message = AirbyteMessage(
type=MessageType.LOG,
Expand Down
Loading