use THREE.Cache for in-memory asset caching (fixes #772) #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
added a commit
that referenced
this pull request
Feb 12, 2016
use THREE.Cache for in-memory asset caching (fixes #772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, because of how entities loads assets asynchronously, this doesn't improve the case of a scene that requests multiple images that share the same URL on page load. Example: http://localhost:9000/examples/showcase-spheres-and-fog/
But if you add a new entity with an asset that has already been loaded (and cached), then a cache hit does in fact happen, and it's served from the in-memory cache.
If the nodes and their assets were loaded sequentially, all subsequent requests would be cache hits. But that's not how things work.
So this isn't a huge improvement, but it'll help in some cases.