Skip to content

Replaces setOBject3D(type, null) with removeObject3D(type) #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2016
Merged

Replaces setOBject3D(type, null) with removeObject3D(type) #847

merged 1 commit into from
Jan 15, 2016

Conversation

@dmarcos
Copy link
Member

@dmarcos dmarcos commented Jan 15, 2016

No description provided.

@dmarcos dmarcos force-pushed the replaceSetObject3D branch from 0d19b81 to 4a2fcfb Compare January 15, 2016 07:16
@ngokevin
Copy link
Member

ngokevin commented Jan 15, 2016

r+, maybe a test
@dmarcos
Copy link
Member Author

dmarcos commented Jan 15, 2016

removeObject3D is just an alias of setObject3D(type, null) and setObject3D is already tested
dmarcos added a commit that referenced this pull request Jan 15, 2016
@dmarcos
Merge pull request #847 from dmarcos/replaceSetObject3D
c057dbc 
Replaces setOBject3D(type, null) with removeObject3D(type)
@dmarcos dmarcos merged commit c057dbc into aframevr:dev Jan 15, 2016
@cvan cvan modified the milestone: 0.2.0 Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dmarcos @ngokevin @cvan