-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
introduce template bundler (fixes #67) and cube template (fixes #49) #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce template bundler (fixes #67) and cube template (fixes #49) #68
Conversation
core/templates/vr-cube.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine these things not getting DRY. thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what case could this get out of hand?
|
updated: added vulcanize to output a single HTML import now the dev has to keep track of two files: the I think this is sufficient. I can simply undo the vulcanize commit in this PR and just ship all the HTML inline in the JS which is what I was doing before. thoughts? I'm looking to merge this ASAP and we can iterate as we continue to develop. |
|
post-push feedback welcome. feel free to provide feedback, ask questions, and file issues for enhancements desired. |
r+ |
r? @jcarpenter @dmarcos @ngokevin