Skip to content

Conversation

@cvan
Copy link
Contributor

@cvan cvan commented Oct 19, 2015

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine these things not getting DRY. thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what case could this get out of hand?

@cvan
Copy link
Contributor Author

cvan commented Oct 20, 2015

updated: added vulcanize to output a single HTML import

now the dev has to keep track of two files: the dist/vr-components.js and dist/vr-components.html. read this article and the comments; great discussion about this inherent issue with dependency management of imports for sharing, reusing, and in our cases releasing a library.

I think this is sufficient. I can simply undo the vulcanize commit in this PR and just ship all the HTML inline in the JS which is what I was doing before.

thoughts? I'm looking to merge this ASAP and we can iterate as we continue to develop.

@cvan
Copy link
Contributor Author

cvan commented Oct 20, 2015

post-push feedback welcome. feel free to provide feedback, ask questions, and file issues for enhancements desired.

@cvan
Copy link
Contributor Author

cvan commented Oct 20, 2015

r+

cvan added a commit that referenced this pull request Oct 20, 2015
introduce template bundler (fixes #67) and cube template (fixes #49)
@cvan cvan merged commit d197f45 into aframevr:master Oct 20, 2015
cvan added a commit that referenced this pull request Nov 30, 2015
introduce template bundler (fixes #67) and cube template (fixes #49)
cvan added a commit that referenced this pull request Dec 9, 2015
introduce template bundler (fixes #67) and cube template (fixes #49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants