Skip to content

Add skysphere template and example #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcarpenter wants to merge 1 commit into from
Closed

Add skysphere template and example #65

jcarpenter wants to merge 1 commit into from

Conversation

@jcarpenter
Copy link

@jcarpenter jcarpenter commented Oct 19, 2015

No description provided.

jcarpenter
jcarpenter reviewed Oct 19, 2015
View reviewed changes
examples/_templates/skysphere/vr-skysphere.html
Copy link
Author

@jcarpenter jcarpenter Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work until we change how paths work. default.jpg does exist in vr-skysphere.html directory.
Copy link
Contributor

@cvan cvan Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #66
Copy link
Contributor

@cvan cvan Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change to url="/examples/_templates/skysphere/default.jpg" for now
Copy link
Contributor

@cvan cvan Oct 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that I've done #67, you can move this to https://github.com/MozVR/vr-components/tree/master/core/templates
@cvan
Copy link
Contributor

cvan commented Oct 19, 2015

besides the above minor things, looks good
@jcarpenter
Copy link
Author

jcarpenter commented Oct 22, 2015

Have a new version of this working on the new code base. Am going to close this and open a new PR tomorrow.
@jcarpenter jcarpenter closed this Oct 22, 2015
@jcarpenter jcarpenter deleted the skysphere branch October 26, 2015 03:39
This was referenced Feb 25, 2019
Closed
Closed
This was referenced Jan 21, 2020
Open
Open
Open
Open
This was referenced Jan 14, 2021
Open
Open
Open
Open
@harunpehlivan harunpehlivan mentioned this pull request Feb 23, 2021
Open
@enterstudio enterstudio mentioned this pull request Feb 24, 2021
Open
@avorona avorona mentioned this pull request Feb 24, 2021
Open
@sshepanski7 sshepanski7 mentioned this pull request Feb 24, 2021
Open
@avorona avorona mentioned this pull request Oct 6, 2022
Open
@preetamherald preetamherald mentioned this pull request Jul 17, 2023
Open
@preetamherald preetamherald mentioned this pull request Nov 25, 2023
Open
@avorona avorona mentioned this pull request Nov 27, 2023
Open
@sshepanski7 sshepanski7 mentioned this pull request Nov 28, 2023
Open
@enterstudio enterstudio mentioned this pull request Nov 29, 2023
Open
@avorona avorona mentioned this pull request May 22, 2024
Open
@enterstudio enterstudio mentioned this pull request May 22, 2024
Open
@preetamherald preetamherald mentioned this pull request May 22, 2024
Open
@sshepanski7 sshepanski7 mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changes needs rebase

2 participants

@jcarpenter @cvan