Fix crash setting transform on undefined when layer is pending recreation #5769
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdateSrc and layer is not yet recreated because image has not loaded yet
vincentfretin
force-pushed
the
fix-layer-recreation
branch
from
149fc2c to
311ca02
Compare
Member
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix crash setting transform on undefined when layer is destroyed in updateSrc and layer is not yet recreated because image has not loaded yet (this.texture is undefined).
Crash reproduced on the Comic book example while in VR switch to the next image. I didn't have the issue on the other layer quad example.
In a592737 I had changed updateSrc to destroy the layer on src change, not sure if I tested again that example after that change or the issue appears now because of my connection, anyway this PR fixes it.
Changes proposed: