Skip to content

Conversation

@vincentfretin
Copy link
Contributor

Description:

In #5632, the line was changed from

canvas.clientWidth = 1000;

that really did nothing because canvas.clientWidth is read-only.

to

assert.isAtLeast(canvas.clientWidth, 1000);

but those tests now fail on my Ubuntu machine, the window opens with width 886.

Changes proposed:

  • Relax the clientWidth constraint in the controls tests to use 800, from the tests it should be a value above 500
@dmarcos
Copy link
Member

dmarcos commented Jan 23, 2025

Thanks

@dmarcos dmarcos merged commit 9ee1b69 into aframevr:master Jan 23, 2025
3 checks passed
@vincentfretin vincentfretin deleted the remove-the-additional-assert branch January 24, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants