Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Jan 17, 2025

Description:
The tracked-controls system unconditionally adds an inputsourcechange listener when "entering VR". However, the enter-vr event is also used when entering fullscreen mode, in which case an error occurs. This is a regression introduced in fd90434.

This PR simply adds a check to make sure there is an XRSession before adding the event listener.

Changes proposed:

  • Check if there's an XRSession before adding inputsourcechange listener in tracked-controls system.
@mrxz mrxz force-pushed the fix-tracked-controls-entervr branch from 916c0ac to be0d4f1 Compare January 21, 2025 07:47
@dmarcos
Copy link
Member

dmarcos commented Jan 22, 2025

Thanks!

@dmarcos dmarcos merged commit 51b70a3 into aframevr:master Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants