Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Mar 4, 2024

Description:
As detailed in #4672, the check performed in the device-orientation-permission-ui component is attempting to determine if the user is accessing the page in a secure context. Using window.isSecureContext for this should be more reliable and avoids false negatives, as the browser knows whether this is the case.

Fixes #4672

Changes proposed:

  • Replace manual check for localhost and/or https with window.isSecureContext
@dmarcos
Copy link
Member

dmarcos commented Mar 5, 2024

Thanks so much!

@dmarcos dmarcos merged commit 9347a59 into aframevr:master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants