Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Dec 19, 2023

Description:
When removing the fog component, the fog wouldn't actually be removed but instead rendered "ineffective" by adjusting the near and far values. This however has two issues:

  • Fog type exponential doesn't use near and far meaning the fog would still be visible after removal
  • Shaders would still perform fog calculations for no reason

Changes proposed:

@dmarcos
Copy link
Member

dmarcos commented Dec 19, 2023

Thank you!

@dmarcos dmarcos merged commit 8e4f387 into aframevr:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants