Skip to content

Set .background null when removing background component #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

Set .background null when removing background component #5417

merged 1 commit into from
Dec 19, 2023

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Dec 19, 2023

Description:
The background component set the scene background to the string value black when removed. Not only is this an invalid value for the background property in Three.js, it also doesn't match the default value from before adding the background component.

Changes proposed:

  • Set sceneEl.object3D.background to null when removing background component
@dmarcos
Copy link
Member

dmarcos commented Dec 19, 2023

Thanks!
@dmarcos dmarcos merged commit fce5b6a into aframevr:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mrxz @dmarcos