Skip to content

Fix bug in handling processSound callback when sound hadn't loaded yet #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix bug in handling processSound callback when sound hadn't loaded yet #5414

merged 1 commit into from
Dec 15, 2023

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Dec 15, 2023

Description:
The changes made in #5365 can result in an error (see #5365 (comment)). The code incorrectly uses this instead of self. This PR fixes it and adds a unit test covering this as well.

Changes proposed:

  • Replace the incorrect this with self
  • Introduce a unit test that verifies that the processSound callback given to playSound is correctly invoked upon the sound loading.
@mrxz mrxz mentioned this pull request Dec 15, 2023
Merged
@arpu
Copy link
Contributor

arpu commented Dec 15, 2023

@mrxz Yes this fixes the Problem! Thanks
@dmarcos
Copy link
Member

dmarcos commented Dec 15, 2023

Thank you very much!
@dmarcos dmarcos merged commit 6882858 into aframevr:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@mrxz @arpu @dmarcos