Skip to content

Remove outdated skinning property to prevent a warning #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

Remove outdated skinning property to prevent a warning #5386

merged 1 commit into from
Nov 17, 2023

Conversation

@avdynut
Copy link
Contributor

@avdynut avdynut commented Nov 16, 2023

When hands are used a warning appears that the skinning property is not part of material
@dmarcos
Copy link
Member

dmarcos commented Nov 16, 2023

Thanks. This seems was needed before. Is there anything else we should do instead besides removing the property?
@avdynut
Copy link
Contributor Author

avdynut commented Nov 17, 2023

I think it can be safely removed, because SkinnedMesh is used. For reference see mrdoob/three.js@8c21891
@dmarcos
Copy link
Member

dmarcos commented Nov 17, 2023

Thanks and congrats for your first contribution 🏅
@dmarcos dmarcos merged commit dac50c5 into aframevr:master Nov 17, 2023
diarmidmackenzie added a commit to diarmidmackenzie/aframe-examples that referenced this pull request Nov 19, 2023
@diarmidmackenzie
Fix warning
0663aeb 
See: aframevr/aframe#5386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@avdynut @dmarcos