Skip to content

Conversation

@DougReeder
Copy link
Contributor

Description:
Fixes #4848
The WebXR standard now defines the grip space such that a cylinder held in a closed hand points along the Z axis. The models currently have such a cylinder point along the X-Axis.

Changes proposed:
There are two approaches

  1. rotate the mesh in code, as done here
  2. edit the GLB files

I'm fine with either, but I lack knowledge of 3D tools (such as Blender) to implement the second approach.

@dmarcos dmarcos changed the title hand-controls: rotates models to match WebXR definition Mar 20, 2023
@dmarcos
Copy link
Member

dmarcos commented Mar 20, 2023

Thanks!. I think we have to check for sceneEl.hasWebXR before applying the offset so WebVR (Firefox) still works as before.

I would also add a comment in the offset:

// The WebXR standard defines the grip space such that a cylinder held in a closed hand points along the Z axis. ./
// The models currently have such a cylinder point along the X-Axis.
var modelOrientationXOffset = sceneEl.hasWebXR ? xxx : 0;
...

@dmarcos
Copy link
Member

dmarcos commented Mar 20, 2023

Thank you!

@dmarcos dmarcos merged commit 5b29ac2 into aframevr:master Mar 20, 2023
@DougReeder DougReeder deleted the grip-space branch April 8, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants