Skip to content
Navigation Menu
Toggle navigation
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Spark
Build and deploy intelligent apps
GitHub Models
Manage and compare prompts
MCP Registry
New
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
Accelerator
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search or jump to...
Search code, repositories, users, issues, pull requests...
Search syntax tips
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Sign in
Sign up
Appearance settings
Resetting focus
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
aframevr
/
aframe
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
4.3k
Star
17.5k
Code
Issues
321
Pull requests
13
Actions
Wiki
Security
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Wiki
Security
Insights
Fix errors when buttons are pressed on Quest 2 controllers before the model is loaded
#5223
Merged
dmarcos
merged 3 commits into
aframevr:master
aframevr/aframe:master
from
vincentfretin:fix-quest2-buttons
vincentfretin/aframe:fix-quest2-buttons
Copy head branch name to clipboard
Mar 30, 2023
Conversation
Commits
3
(3)
Checks
Files changed
Merged
Fix errors when buttons are pressed on Quest 2 controllers before the model is loaded
#5223
dmarcos
merged 3 commits into
aframevr:master
aframevr/aframe:master
from
vincentfretin:fix-quest2-buttons
vincentfretin/aframe:fix-quest2-buttons
Copy head branch name to clipboard
Commits
Commits on Jan 21, 2023
Check if buttonObjects or buttonMeshes is defined before accessing it, this fixes Quest 2 buttons highlighting errors when the model is not loaded yet (fix #5212 and #5220)
vincentfretin
committed
b569016
Copy full SHA for b569016
Commits on Jan 26, 2023
check this.buttonMeshes before calling this.onButtonChangedV3
vincentfretin
committed
7b2cda9
Copy full SHA for 7b2cda9
Revert "check this.buttonMeshes before calling this.onButtonChangedV3"
Show description for cf102c8
vincentfretin
committed
cf102c8
Copy full SHA for cf102c8
You can’t perform that action at this time.
