Skip to content

Fix quest 1 controller and ray offsets #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2022
Merged

Fix quest 1 controller and ray offsets #5190

merged 1 commit into from
Dec 24, 2022

Conversation

@vincentfretin
Copy link
Contributor

@vincentfretin vincentfretin commented Dec 24, 2022

Description:

I tweaked the values by trial and error.
This close #5183

Changes proposed:

  • Modify modelPivotOffset modelPivotRotation rayOrigin for oculus-touch-v2 that are used for Quest 1 controllers
@vincentfretin vincentfretin mentioned this pull request Dec 24, 2022
Closed
@dmarcos
Copy link
Member

dmarcos commented Dec 24, 2022

Merging this for now. We need to get rid of these harcoded values in the future. I believe we can retrieve the orientation and position of the laser from the WebXR API itself.
@dmarcos dmarcos merged commit 4ae59b8 into aframevr:master Dec 24, 2022
@vincentfretin vincentfretin deleted the fix-quest-controllers branch March 31, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vincentfretin @dmarcos