-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Set up GitHub CI #5092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up GitHub CI #5092
Conversation
|
Note that codecov upload should work, but I can't test it on my fork. It finds the I set up testing only on chrome, but you can enable it for firefox if you want, it's just commented. |
|
I enabled the tests on firefox, it seems fine. You'll see if there are some tests that are randomly failing on Firefox or not later on other PRs. If there is an issue with it, just comment it. You can merge this PR and close the first one, or merge the first one, then I rebase this one and you merge, as you wish. |
|
Compared to the previous travis config, I added a check for the minified build that runs |
|
codecov upload is working, it uploaded the results from this PR: |
| karma.conf.js | ||
| node_modules | ||
| npm-debug.log* | ||
| package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I explained it in #5092 (comment)
see documentation https://github.com/actions/setup-node#caching-global-packages-data
|
It needs rebase! |
0578635 to
c3b724c
Compare
|
I rebased. |
|
About putting |
c3b724c to
cfb1694
Compare
|
done, good to merge |
|
Thanks so much! This is great work. Tests don't get much love. I let them rotten a little bit 😄 |
This is based on #5091. I can rebase this PR once the first one is merged.
This PR removes travis and the old codecov uploader, replaces it by GitHub Actions.
You can see a successful pipeline here
https://github.com/vincentfretin/aframe/actions/runs/2868225958