Skip to content

Fix bug with removal of line with __suffix component name (fix #5080) #5081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmarcos merged 1 commit into from
Jul 21, 2022
Merged

Fix bug with removal of line with __suffix component name (fix #5080) #5081

dmarcos merged 1 commit into from
Jul 21, 2022

Conversation

@diarmidmackenzie
Copy link
Contributor

@diarmidmackenzie diarmidmackenzie commented Jul 19, 2022

Description:

Fix for bug described in issue 5080

Changes proposed:

  • Use correct name when removing "line" Object3D
  • Added Unit Test to cover line__suffix style component.
@dmarcos
Copy link
Member

dmarcos commented Jul 21, 2022

Great catch. Thanks so much! And 🥇 for adding a test.
@dmarcos dmarcos changed the title Fix bug with removal of line with __suffix component name Jul 21, 2022
@dmarcos dmarcos merged commit 32286e3 into aframevr:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@diarmidmackenzie @dmarcos