Skip to content

Fix maxCanvas embedded #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmarcos merged 1 commit into from
Feb 3, 2022
Merged

Fix maxCanvas embedded #4912

dmarcos merged 1 commit into from
Feb 3, 2022

Conversation

@s-light
Copy link
Contributor

@s-light s-light commented Aug 24, 2021

Description:
fixes #4911
testcase:
https://codepen.io/s-light/pen/NWgWoJm?editors=1001

Changes proposed:

  • extract constrainSizeTo from getMaxSize
  • add constrainSizeTo for embedded mode
  • build dist for testcase.
@s-light s-light mentioned this pull request Aug 24, 2021
Closed
@dmarcos dmarcos force-pushed the fix_maxCanvas_embedded branch from de5ecf4 to 2696c4f Compare February 2, 2022 00:21
@dmarcos dmarcos force-pushed the fix_maxCanvas_embedded branch from 2696c4f to 5bc1836 Compare February 3, 2022 01:30
@dmarcos
Copy link
Member

dmarcos commented Feb 3, 2022

Thanks for the patience! Congrats on your first contribution 🥇
@dmarcos dmarcos merged commit 0dd84ab into aframevr:master Feb 3, 2022
@s-light
Copy link
Contributor Author

s-light commented Feb 3, 2022

thanks for merging!!
@s-light s-light deleted the fix_maxCanvas_embedded branch February 3, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@s-light @dmarcos