Skip to content

Use proper THREE.Cache API in a-assets.js #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

Use proper THREE.Cache API in a-assets.js #4864

merged 1 commit into from
May 24, 2021

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented May 21, 2021

Fixes #4861

Description:

Refer to #4861 for the detail.

Changes proposed:

  • Replace THREE.Cache.files[url] = file with likely more proper API THREE.Cache.add(url, file).
@dmarcos
Copy link
Member

dmarcos commented May 24, 2021

Thank you!
@dmarcos dmarcos merged commit bbd27c7 into aframevr:master May 24, 2021
@takahirox takahirox deleted the ThreeCacheAdd branch May 24, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@takahirox @dmarcos