Skip to content

Fix raycaster overriding line default color #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Fix raycaster overriding line default color #4743

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6afe067
Let Line component define the default color
GMartigny Dec 8, 2020
2c087f2
Fix default value
GMartigny Dec 8, 2020
4d965a7
Add lineOpacity option to raycaster
GMartigny Dec 9, 2020
c7ba9f1
Update documentation
GMartigny Dec 9, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Let Line component define the default color
  • Loading branch information
@GMartigny
GMartigny committed Dec 8, 2020
commit 6afe067bc997e5dfdbedcfd055c1cf681c4a05bf
6 changes: 3 additions & 3 deletions src/components/raycaster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module.exports.Component = registerComponent('raycaster', {
objects: {default: ''},
origin: {type: 'vec3'},
showLine: {default: false},
lineColor: {default: 'white'},
lineColor: {},
useWorldCoordinates: {default: false}
},

Expand Down Expand Up @@ -200,7 +200,7 @@ module.exports.Component = registerComponent('raycaster', {
},

/**
* Raycast for intersections and emit events for current and cleared inersections.
* Raycast for intersections and emit events for current and cleared intersections.
*/
checkIntersections: function () {
var clearedIntersectedEls = this.clearedIntersectedEls;
Expand Down Expand Up @@ -386,7 +386,7 @@ module.exports.Component = registerComponent('raycaster', {
* Children are flattened by one level, removing the THREE.Group wrapper,
* so that non-recursive raycasting remains useful.
*
* Only push children defined as component attachemnts (e.g., setObject3D),
* Only push children defined as component attachements (e.g., setObject3D),
* NOT actual children in the scene graph hierarchy.
*
* @param {Array<Element>} els
Expand Down