Skip to content

fix ie 11 fullscreen mode bug #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

fix ie 11 fullscreen mode bug #4243

merged 2 commits into from
Aug 5, 2019

Conversation

@AlexandraWins
Copy link
Contributor

@AlexandraWins AlexandraWins commented Aug 2, 2019

exit fullscreen mode in IE correctly

Description:
Currently fullscreen mode is not exited correctly in IE11 on a Desktop device. It is only possible to see images in fullscreen once. As soon as fullscreen is exited, fullscreen button is gone.
Changes proposed:

  • add exit fullscreen mode event listener for IE
@AlexandraWins
fix ie 11 fullscreen mode bug
3e9a9c1 
exit fullscreen mode in ie correctly
dmarcos
dmarcos reviewed Aug 4, 2019
View reviewed changes
Copy link
Member

@dmarcos dmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
@dmarcos
Copy link
Member

dmarcos commented Aug 5, 2019

@AlexandraWins There's a linter issue. Extra space at the end of the line (https://github.com/aframevr/aframe/pull/4243/files#diff-eb9bb1084863a2f65678ea67d6e7cf5eR845). We can merge after fix
@AlexandraWins
Copy link
Contributor Author

AlexandraWins commented Aug 5, 2019

thanks for feedback @dmarcos
@dmarcos
Copy link
Member

dmarcos commented Aug 5, 2019

Thanks
@dmarcos dmarcos merged commit b644173 into aframevr:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@AlexandraWins @dmarcos