Prevent multiple requestPresent calls if vrDevice is already presenti… #4148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
force-pushed
the
wrongCanvasSize
branch
2 times, most recently
from
88db2d5 to
ef77d6f
Compare
…ng in polyfilled mode. It prevents a wrong sized canvas when enter VR in iOS. Multiple requestPresent calls are allowed in 0.9.1 for in-vr navigation but not necessary in cardboard mode since immersive navigation is not possible (fix aframevr#4142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng in polyfilled mode. It prevents a wrong sized canvas when entering VR in iOS. Multiple requestPresent calls are allowed in 0.9.1 for in-vr navigation but not necessary in cardboard mode since immersive navigation is not possible (fix #4142)