Remove extra properties from objectPool objects #4016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, I'll take a look later. |
ngokevin
reviewed
Feb 16, 2019
|
|
||
| // Store component data from previous update call. | ||
| this.attrValue = undefined; | ||
| this.nextData = this.isObjectBased ? this.objectPool.use() : undefined; |
Member
There was a problem hiding this comment.
Perhaps I'd just add a keysFilter argument to objectPool.use and pass the schema in versus a separate function.
This was referenced Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ngokevin what do you think of this approach?
Description: Prevents keys added to component data pooled objectss by dynamic schemas from appearing in other instances of the component. Only needs to be done on initialization because the object copy methods used in the update cycle already skip over keys with undefined values. Should have no effect for components without dynamic schemas.
Close #4012
Changes proposed:
utils.objectPool.removeUnusedKeysdeletes properties not found in a reference object (i.e. the component template schema)