Skip to content

remove some memory allocations from material code #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2018
Merged

remove some memory allocations from material code #3789

merged 1 commit into from
Oct 6, 2018

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Oct 5, 2018 •
edited
Loading

Description:

Changes proposed:

  • 5 object.keys
  • 4 function callbacks
  • 3 THREE.Color
  • 2 object literals
@dmarcos dmarcos merged commit 638d58e into aframevr:master Oct 6, 2018
This was referenced Sep 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos