Add configurable loading screen. #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
force-pushed
the
loadingScreen
branch
4 times, most recently
from
96735eb to
3bf560c
Compare
ngokevin
reviewed
Sep 9, 2018
src/core/scene/a-scene.js
Outdated
| writable: true | ||
| }, | ||
|
|
||
| setupLoader: { |
Member
There was a problem hiding this comment.
Can place all the loader code in a module that exports functions setupLoader(sceneEl) to not pollute scope, not meant to be callable by user
src/core/scene/a-scene.js
Outdated
|
|
||
| setupLoader: { | ||
| value: function () { | ||
| var self = this; |
Member
There was a problem hiding this comment.
a little daunting to read a web of instantiations that aren't used until later in various places. need to jump up/down the function to follow.
src/core/scene/a-scene.js
Outdated
| writable: true | ||
| }, | ||
|
|
||
| removeLoader: { |
Member
There was a problem hiding this comment.
Can also free the created geometry/materials
Member
Author
|
@ngokevin This is ready to go:
|
Member
|
I'd document the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Loading screen to avoid blank screen while loading assets and scene render loop has not yet started. The loader animation doesn't require 60fps to mask main thread pauses.
The logic is a
pseudo-componentsince it has to initialize and render while the assets load.The title of the page is displayed above the loading indicator.
The color of the dots, background and style of the title bar are configurable.