clear raycaster intersections when disabled (fixes #3593) #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
May 22, 2018
| intersection: 'raycaster-intersection', | ||
| intersectClear: 'raycaster-intersected-cleared', | ||
| intersectionClear: 'raycaster-intersection-cleared' | ||
| }; |
Member
There was a problem hiding this comment.
nit: it would be slightly more idiomatic to use this capitalization:
var Event = {
INTERSECT: 'raycaster-intersected',
// ...
};
| : this.removeEventListeners(); | ||
| } | ||
|
|
||
| if (oldData.enabled && !data.enabled) { this.clearAllIntersections(); } |
Member
There was a problem hiding this comment.
Let's also invoke this method on remove().
ngokevin
force-pushed
the
raycasterclear
branch
2 times, most recently
from
282c944 to
8931ec7
Compare
Member
Author
|
Addressed / ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix an issue where entities would not get
mouseleaved when raycaster was disabled.Changes proposed: