<vr-template> #34
<vr-template> #34
Conversation
examples/template/box-import.html
Outdated
There was a problem hiding this comment.
E/C PR was updated to rename this to vr-mixin.
There was a problem hiding this comment.
yep, gotta pull and rebase
|
fyi: I actually added mutation observers to the |
core/vr-template.js
Outdated
There was a problem hiding this comment.
this is to support Chrome's native imports. need to revisit a solution. can show you in person.
There was a problem hiding this comment.
This is your library so I let you decide but I'm always skeptical about this marginal value utility functions. More code to maintain and document where bugs can hide and it replaces a well known standard API with your own jargon making the code harder to understand for newcomers to the project.
There was a problem hiding this comment.
that's a valid point. I had to Array.prototype.slice.call(document.querySelectorAll) 8 times so I thought I should make a function out of it. that gets pretty verbose quickly. thoughts?
There was a problem hiding this comment.
Same function in vr-assets, vr-scene and vr-template
|
woo! |
There was a problem hiding this comment.
Can we call the attribute element="vr-bigcubes"?
Created skysphere and updated skybox to match best practices
3 participants
https://cvan.io/vr-components/examples/template/
dependent on ngokevin/aframe-core#266